Adds "is_managed" key in Parse.ly Integration if integration is managed by VIP #4802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4802 +/- ##
==========================================
Coverage 28.98% 28.98%
Complexity 4692 4692
==========================================
Files 276 276
Lines 20711 20711
==========================================
Hits 6004 6004
Misses 14707 14707
|
mehmoodak
force-pushed
the
vip-parsely-61/adds-is-managed-attribute-on-parsely-integration
branch
from
2bd16ca
to
701ec7e
Compare
mehmoodak
changed the title
| return array( | ||
| // If config provided by VIP is empty then take original credentials else take | ||
| // credentials from config. | ||
| $credentials = empty( $config ) ? $original_credentials : array( |
There was a problem hiding this comment.
Small suggestion - may be better to check for the keys you need explicitly (site_id and api_secret) rather than any $config value. If $config currently or in the future accepts other configuration keys, this code would set both values to null if any other configuration key is set.
Suggested change
| $credentials = empty( $config ) ? $original_credentials : array( | |
| $credentials = ( isset( $config[ 'site_id' ] ) && isset( $config[ 'api_secret' ] ) ? array( ... ) : $original_credentials; |
(note this implementation switches the order of the array values and $original_credentials)
There was a problem hiding this comment.
$original_credentials means credentials that we got from plugin so I think its fine to return as it is without any extra checks to keep things simple. Later we can improve if needed.
alecgeatches
approved these changes
Aug 21, 2023
mehmoodak
deleted the
vip-parsely-61/adds-is-managed-attribute-on-parsely-integration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default we shows a banner on the plugin which let customers know to add credentials but for integration enabled via VIP we don't want to show this banner because if the site is yet to launch then we don't have its domain and without domain we cannot setup Parse.ly credentials so enabling the integration properly is a two step process:
Enable the integration when environment is init so that customers are already aware of Parse.ly and don't have surprises or unexpected behavior during launch.
Configure the integration ( i.e. setup credentials ) after the launch.
Changes Made
Changelog Description
Adds "is_managed" key in Parse.ly Integration if managed by VIP
Pre-review checklist
Please make sure the items below have been covered before requesting a review:
Pre-deploy checklist
Steps to Test
wp_parsely_credentialsfilter (git clone [email protected]:Parsely/wp-parsely.git wp-parsely-3.8)